Test case for token response scope differing from token request scope#856
Merged
Test case for token response scope differing from token request scope#856
Conversation
neha-bhargava
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: This PR only adds a test case. It does not change any existing behavior of MSAL Python. It is safe to merge it in.
Context: Recently we got involved in a cross-team investigation for a high-profile incident. Result indicates that this code base does token caching right, nonetheless it was still time-consuming to self-audit and then validate the cache behavior for the scenario of "token response scope differing from token request scope". So, as a byproduct of this investigation, here comes this PR containing a dedicated test case to validate the following behaviors:
Once this test case is added and rerun all the time, we won't need to second guess ourselves in any future troubleshooting.